Fix macOS filesystem security: use `/etc/paths.d/TinyTeX` when `/usr/local/bin` is not writable by Copilot · Pull Request #489 · rstudio/tinytex

Copilot · 2026-03-06T21:49:21Z

TinyTeX was recursively changing ownership of /usr/local/bin (chown -R) — affecting all pre-existing binaries unrelated to TinyTeX — and creating symlinks from /usr/local/bin into the user's home directory. This PR eliminates unsafe /usr/local/bin manipulation on macOS, with a graceful fallback for users who have already made /usr/local/bin writable.

Changes

R/install.R

Remove check_local_bin() entirely
Add macos_local_bin_writable() helper (file.access('/usr/local/bin', 2) == 0)
Factor out macos_path(dir, action) helper used by both tlmgr_path() and use_tinytex(); skips writing /etc/paths.d/TinyTeX if it already contains the desired path (idempotent)
osascript(): emits message() before running to inform users of the command requiring the password; on failure emits warning() without repeating the command; escapes double-quotes in the shell command internally (keeping the original cmd for the message)
macos_path(): paths passed to shell commands are quoted to handle paths containing spaces; temp file is only deleted if osascript succeeds
use_tinytex(): uses macos_path() only when is_macos() && !macos_local_bin_writable(); warns on failure
add_path parameter doc simplified to link to tlmgr_path()

R/tlmgr.R

Factor out find_tinytex_bin() helper to avoid duplicating tweak_path() logic
tlmgr_path(): on macOS, uses macos_path() (writing to /etc/paths.d/TinyTeX) only when /usr/local/bin is not writable; if /usr/local/bin is writable, falls back to the existing tlmgr path add/remove behavior (preserving existing users' setups); on Linux/Windows the existing behavior is unchanged

tools/install-bin-unix.sh

On macOS: if /usr/local/bin is writable, use ./tlmgr path add; otherwise write the current bin directory to /etc/paths.d/TinyTeX via sudo tee (skipped if already up-to-date)
Supports a --no-path argument to skip PATH manipulation for any OS (detected by scanning all arguments, not assuming a fixed position)
On sudo failure: echoes a manual export PATH=$PATH:<bindir> command with instructions to add it to the shell startup profile; also runs the export immediately so the current shell session picks up the path without a restart
On Linux: unchanged ./tlmgr path add

tools/install-unx.sh

Unchanged from upstream (this script is primarily used for building binary TinyTeX in GHA, not for end-user macOS installs)

# Before (R/install.R)
osascript(sprintf('chown -R %s:admin %s', user, p))  # recursive chown on /usr/local/bin
# + tlmgr path add  (creates symlinks in /usr/local/bin -> ~/Library/TinyTeX/bin/*)

# After (R/tlmgr.R - tlmgr_path on macOS, /usr/local/bin not writable)
macos_path(find_tinytex_bin(), action)  # writes bin path to /etc/paths.d/TinyTeX; no /usr/local/bin involved

# After (R/tlmgr.R - tlmgr_path on macOS, /usr/local/bin is writable)
tlmgr(c('path', action))  # existing behavior preserved for users who already chmod'd /usr/local/bin

Original prompt

This section details on the original issue you should resolve

<issue_title>fix filesystem security issues</issue_title>
<issue_description>From #24 (comment):

/usr/local/bin should be writable by default on (at least recent versions of) macOS.

Please no 🤦 . No R package should ever automatically/directly change permissions on a file/directory outside of the user's home directory¹, nor encourage it as a long-term solution. Further, your script is changing ownership for files that have nothing at all to do with TinyTex. Lastly, setting up symlinks from /usr/local/bin/ into any user's /Users/*/bin/ is as bad if not worse than changing the ownership of /usr/local/bin/; even if that one user keeps it up to date, it is bad practice and has risks.

There are two ways to do it "responsibly" (from an OS security mindset):

Setup a Homebrew formula so that it can be installed and managed in a central location /opt/homebrew/..., usable to all users, and does not allow users to access other users' home directory contents. The presumption here is that the setup of Homebrew is permitted by a local user, and if on a multi-user system, who can do what with brew is for them to decide (not an R package maintainer ... no offense intended).
I confess that I don't know homebrew well enough to be able to help much with this approach.

Initially install completely to a local or temporary location, then use the ocascript "with administrator privileges" trick for moving everything to /usr/local/bin/ and /usr/local/share/TinyTex/, no symlinks required. This supports multi-users just as natively without any fearsome user-directory-breach nor any permanent side-effects such as from chown.

I might be willing to help with number 2, though I apologize it will not happen any time soon. But I think that's a much preferred way-forward than the current method.

As a temporary step, can you do one or more of the following:

Add what the original owner/group were changed from? On my system I think it's root:staff but I can't know now. This allows security-obsessed people like me to undo the change to what it was before.

There should be no need to recursively change all non-TinyTex contents of /usr/local/bin/ to be owned by me, please remove the -R from chown -R. (This should never have been needed in the first place, this removal should have zero effect on the installation.)

Once installation is done, undo the change (using ocascript a second time) on /usr/local/bin/ (again, no need for recursive changes).

^{1: When external non-R software is required, if *that* software has a script that handles multi-user situations, then that is IMO an acceptable solution. No software I've ever installed on linux ever attempted to change ownership of `/usr/local/bin`, for many good reasons. Now that I've moved to MacOS, I continue the unix-y security mindsets, most of which Apple agrees with.}
Comments on the Issue (you are @copilot in this section)

Fixes fix filesystem security issues #463

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

CLAassistant · 2026-03-06T21:49:28Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ yihui
❌ Copilot
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

…l/bin ownership after install Co-authored-by: yihui <163582+yihui@users.noreply.github.com>

…-filesystem-security-issues

yihui

instead of restoring ownership, let's use a different approach to solve the problem:

we don't tamper with /usr/local/bin at all, but use sudo only once to add TinyTeX's bin path to /etc/paths.d, e.g.

sudo echo path/to/TinyTeX/bin/* > /etc/paths.d/TinyTeX

then we should avoid tlmgr path add for macOS in all places; this command is called in several places in this package, some are through the R function tinytex::tlmgr_path() and some are tlmgr path add commands directly; please find out all of them and avoid them for macOS

the osascript() call in R should only do this /etc/paths.d operation and nothing else; i think we can get rid of check_local_bin() entirely since /usr/local/bin is no longer relevant

Agent-Logs-Url: https://github.com/rstudio/tinytex/sessions/13dd76fe-b745-4b61-8faf-aa3314531d3e Co-authored-by: yihui <163582+yihui@users.noreply.github.com>

Copilot · 2026-03-27T06:39:11Z

instead of restoring ownership, let's use a different approach to solve the problem:

we don't tamper with /usr/local/bin at all, but use sudo only once to add TinyTeX's bin path to /etc/paths.d, e.g....

Done in eea0101.

The approach now:

No /usr/local/bin changes at all — check_local_bin() is removed entirely
On macOS, tlmgr_path('add') writes the TinyTeX bin dir path to /etc/paths.d/TinyTeX via osascript/sudo tee; tlmgr_path('remove') deletes that file
On Linux/non-macOS, the existing tlmgr path add/remove behavior is unchanged
All shell scripts (install-bin-unix.sh, install-unx.sh) have the same macOS/non-macOS split
use_tinytex() on macOS also uses the /etc/paths.d approach instead of tlmgr path add
osascript() is now only used for the /etc/paths.d operations

yihui

remember to roxygenize after doc changes

yihui · 2026-03-27T14:21:24Z

R/install.R

+#' @param add_path Whether to add the bin path of TeX Live to the system
+#'   environment variable \var{PATH}. On macOS, this writes the bin path to
+#'   \file{/etc/paths.d/TinyTeX}; on Linux, it runs \command{tlmgr path add};
+#'   on Windows, it runs \command{tlmgr path add}.


document the details in tlmgr_path and don't repeat in other places

Suggested change

#' @param add_path Whether to add the bin path of TeX Live to the system

#' environment variable \var{PATH}. On macOS, this writes the bin path to

#' \file{/etc/paths.d/TinyTeX}; on Linux, it runs \command{tlmgr path add};

#' on Windows, it runs \command{tlmgr path add}.

#' @param add_path Whether to add the bin path of TeX Live to the system

#' environment variable \var{PATH}. See \code{\link{tlmgr_path}()}.

Done in 76970e1.

yihui · 2026-03-27T14:21:57Z

R/install.R

+#' \code{use_tinytex()} adds the copy of TinyTeX in an existing folder to the
+#' \code{PATH} variable of the current system (on macOS via
+#' \file{/etc/paths.d/TinyTeX}; on other platforms via \command{tlmgr path add}),
+#' so that you can use utilities such as \command{tlmgr} and \command{pdflatex},


don't mention OS details; link to tlmgr_path documentation

Done in 76970e1.

yihui · 2026-03-27T14:29:21Z

R/tlmgr.R

+    paths_file = '/etc/paths.d/TinyTeX'
+    if (action == 'add') {
+      f = getOption('tinytex.tlmgr.path', find_tlmgr(extra = TRUE))
+      if (length(f) == 0 || !file_test('-x', f)) return(invisible(1L))
+      bin = normalizePath(dirname(f))
+      tmp = tempfile(tmpdir = '/tmp')
+      writeLines(bin, tmp)
+      osascript(sprintf('cp %s %s', tmp, paths_file))
+      unlink(tmp)
+    } else {
+      osascript(sprintf('rm -f %s', paths_file))
+    }


factor out a function macos_path(dir, add = TRUE) so it can be reused both here and in use_tinytex(), where dir is the bin path; this function should check if /etc/paths.d/TinyTeX already exists and contains the desired bin path; if it does, we should skip the creation of this file; the same check should be done in *.sh scripts, too

Done in 76970e1 — macos_path(dir, add) is factored out and used by both tlmgr_path() and use_tinytex(). It checks grep -qxF in the shell scripts and readLines + identical in R to skip the write when the file already contains the desired path.

yihui · 2026-03-27T14:30:00Z

R/tlmgr.R

+      f = getOption('tinytex.tlmgr.path', find_tlmgr(extra = TRUE))
+      if (length(f) == 0 || !file_test('-x', f)) return(invisible(1L))
+      bin = normalizePath(dirname(f))


this is repeating the code in tweak_path(); please always factor out, never copy

Done in 76970e1 — factored out as find_tinytex_bin() which both tweak_path() and tlmgr_path() (via macos_path()) now use.

yihui · 2026-03-27T14:30:52Z

tools/install-bin-unix.sh

-  fi
+  # add TinyTeX's bin path to /etc/paths.d instead of creating symlinks in /usr/local/bin
+  # (at this point we are in $TEXDIR/bin/*/ after the `cd` above)
+  TINYTEX_BINDIR="$(pwd)"


this var is not used elsewhere; inline it into printf call next

Done in 76970e1.

yihui · 2026-03-27T14:32:19Z

R/tlmgr.R

+    } else {
+      osascript(sprintf('rm -f %s', paths_file))
+    }
+    return(invisible(0L))


return status code of osascript()

Done in 76970e1 — osascript() now captures and returns the exit status, and macos_path() propagates it via invisible(osascript(...)). tlmgr_path() returns invisible(macos_path(...)) on macOS.

yihui · 2026-03-27T14:48:08Z

R/tlmgr.R

+      f = getOption('tinytex.tlmgr.path', find_tlmgr(extra = TRUE))
+      if (length(f) == 0 || !file_test('-x', f)) return(invisible(1L))
+      bin = normalizePath(dirname(f))
+      tmp = tempfile(tmpdir = '/tmp')


i don't think there's any reason to specify a hardcoded tmpdir

Suggested change

tmp = tempfile(tmpdir = '/tmp')

tmp = tempfile()

Done in 76970e1.

…ncy, osascript returns status, roxygenize Agent-Logs-Url: https://github.com/rstudio/tinytex/sessions/3a5f54ec-a104-4514-843a-93ea370973bf Co-authored-by: yihui <163582+yihui@users.noreply.github.com>

Copilot · 2026-03-27T14:58:17Z

remember to roxygenize after doc changes

Done in 76970e1 — man pages updated to match the doc changes.

yihui

revert changes in tools/install-unx.sh; it should be rare that any macOS user would run this script; the script is mainly used for building binary TinyTeX in our GHA

in tools/install-bin-unix.sh, is it possible to add support for a --no-path argument? if this flag is given, skip the PATH manipulation

yihui · 2026-03-27T15:41:46Z

tools/install-bin-unix.sh

+  # (at this point we are in $TEXDIR/bin/*/ after the `cd` above)
+  if ! grep -qxF "$(pwd)" /etc/paths.d/TinyTeX 2>/dev/null; then
+    echo "Admin privilege (password) is required to set up the PATH for TinyTeX:"
+    printf '%s\n' "$(pwd)" | sudo tee /etc/paths.d/TinyTeX > /dev/null


if this fails (e.g. user gave up password input), echo a message telling users how to set up PATH; the command would be something like export PATH=$PATH:$(pwd) (note that in the message, $PATH shouldn't be expanded and $(pwd) should), and this command should be added to their shell startup profile

also run this export command right here, because the /etc/paths.d won't be picked up until the shell is restarted

Done in 14a151f — on sudo failure, we echo the manual export PATH=$PATH:$(pwd) command with instructions to add it to the shell startup profile. In both success and failure cases, export PATH="$PATH:$(pwd)" is run immediately so the current shell picks it up without a restart.

yihui · 2026-03-27T17:25:55Z

R/install.R

+
+# add/remove TinyTeX's bin path to/from /etc/paths.d/TinyTeX on macOS;
+# if adding and the file already contains the desired path, skip the operation
+macos_path = function(dir = NULL, add = TRUE) {


use the argument action to be consistent with tlmgr_path():

Suggested change

macos_path = function(dir = NULL, add = TRUE) {

macos_path = function(dir = NULL, action = 'add') {

Done in 14a151f.

yihui · 2026-03-27T17:26:27Z

R/install.R

    "Please run this command in your Terminal (password required):\n  sudo ",
    cmd, call. = FALSE
  )
+  invisible(ret)


Suggested change

invisible(ret)

ret

Done in 14a151f.

yihui · 2026-03-27T17:29:15Z

R/install.R

+  if (is_macos()) {
+    macos_path(normalizePath(d))
+  } else if (system2(p, c('path', 'add')) != 0) stop(


for macOS, we also need to stop() when exit status is not 0

Done in 14a151f.

yihui · 2026-03-27T17:30:55Z

R/install.R

+  if (add) {
+    if (is.null(dir) || dir == '') return(invisible(1L))
+    if (file.exists(paths_file) &&
+        identical(trimws(readLines(paths_file, warn = FALSE)), dir))
+      return(invisible(0L))
+    tmp = tempfile()
+    on.exit(unlink(tmp), add = TRUE)
+    writeLines(dir, tmp)
+    invisible(osascript(sprintf('cp %s %s', tmp, paths_file)))
+  } else {
+    invisible(osascript(sprintf('rm -f %s', paths_file)))
+  }


Suggested change

if (add) {

if (is.null(dir) || dir == '') return(invisible(1L))

if (file.exists(paths_file) &&

identical(trimws(readLines(paths_file, warn = FALSE)), dir))

return(invisible(0L))

tmp = tempfile()

on.exit(unlink(tmp), add = TRUE)

writeLines(dir, tmp)

invisible(osascript(sprintf('cp %s %s', tmp, paths_file)))

} else {

invisible(osascript(sprintf('rm -f %s', paths_file)))

}

cmd = if (add) {

if (is.null(dir) || dir == '') return(1L)

if (file.exists(paths_file) &&

identical(readLines(paths_file, warn = FALSE), dir))

return(0L)

tmp = tempfile()

on.exit(unlink(tmp), add = TRUE)

writeLines(dir, tmp)

sprintf('cp %s %s', tmp, paths_file))

} else {

sprintf('rm -f %s', paths_file)

}

osascript(cmd)

Done in 14a151f.

yihui · 2026-03-27T17:33:12Z

R/tlmgr.R

+  if (is_macos()) return(invisible(macos_path(find_tinytex_bin(), action == 'add')))
+  tlmgr(c('path', action), .quiet = TRUE)


Suggested change

if (is_macos()) return(invisible(macos_path(find_tinytex_bin(), action == 'add')))

tlmgr(c('path', action), .quiet = TRUE)

if (is_macos()) {

invisible(macos_path(find_tinytex_bin(), action == 'add'))

} else tlmgr(c('path', action), .quiet = TRUE)

Done in 14a151f.

…acos_path refactor Agent-Logs-Url: https://github.com/rstudio/tinytex/sessions/4ed6cb3b-42e3-4296-9381-ea23c5541e30 Co-authored-by: yihui <163582+yihui@users.noreply.github.com>

Copilot · 2026-03-27T17:37:49Z

revert changes in tools/install-unx.sh; it should be rare that any macOS user would run this script; the script is mainly used for building binary TinyTeX in our GHA

in tools/install-bin-unix.sh, i...

Done in 14a151f — tools/install-unx.sh is reverted to the original. tools/install-bin-unix.sh now accepts a --no-path argument to skip PATH manipulation.

yihui · 2026-03-27T17:45:07Z

tools/install-bin-unix.sh

-    sudo chown -R `whoami`:admin /usr/local/bin
+  # add TinyTeX's bin path to /etc/paths.d instead of creating symlinks in /usr/local/bin
+  # (at this point we are in $TEXDIR/bin/*/ after the `cd` above)
+  if [ "$1" != '--no-path' ] && ! grep -qxF "$(pwd)" /etc/paths.d/TinyTeX 2>/dev/null; then


two issues:

the --no-path argument is not only for macOS, so raise the condition to the top; when --no-path is present, just skip path manipulation for any OS

is there a way to way to test the presence of --no-path without assuming it's $1?

Done in 67441ce. The --no-path detection now scans all arguments via a for arg in "$@" loop and sets a NO_PATH flag. The entire path manipulation block (both Darwin and Linux branches) is wrapped under if [ $NO_PATH -eq 0 ], so the flag applies to any OS.

yihui · 2026-03-27T17:49:08Z

R/install.R

+  if (is_macos()) {
+    if (macos_path(normalizePath(d)) != 0) stop(
+      "Failed to add '", d, "' to /etc/paths.d/TinyTeX. You may consider the fallback ",
+      "approach, i.e., set options(tinytex.tlmgr.path = '", p, "')."
+    )
+  } else if (system2(p, c('path', 'add')) != 0) stop(
    "Failed to add '", d, "' to your system's environment variable PATH. You may ",
    "consider the fallback approach, i.e., set options(tinytex.tlmgr.path = '", p, "')."
  )


too much repetition in the two messages; consolidate into one stop() call; it's fine to use the second message for the macOS case, even though the description is not totally accurate

Done in 67441ce — both branches now assign to ret and share a single stop() call using the second message.

yihui · 2026-03-27T17:50:38Z

R/install.R

+    sprintf('cp %s %s', tmp, paths_file)
+  } else {
+    sprintf('rm -f %s', paths_file)


do these paths need to be quoted somehow? what if they contain spaces or literal quotes? would osascript fail in that case?

Done in 67441ce. Paths are now wrapped with \" (backslash-escaped double quotes) in the shell command string: sprintf('cp \\"%s\\" \\"%s\\"', tmp, paths_file). This produces a command like cp \"/path/with spaces\" \"/etc/paths.d/TinyTeX\", which AppleScript's do shell script correctly interprets as double-quoted shell arguments, handling spaces in paths. Literal double-quotes in paths (extremely unusual for file paths) are not handled, but that edge case is not a practical concern.

yihui · 2026-03-27T17:53:16Z

R/install.R

+        identical(readLines(paths_file, warn = FALSE), dir))
+      return(0L)
+    tmp = tempfile()
+    on.exit(unlink(tmp), add = TRUE)


shouldn't unlink tmp on exit because the osascript command may fail, in which case we should keep tmp, otherwise the warning() message in osascript() will point users to a nonexistent file to cp/rm

unlink tmp only if osascript succeeds

Done in 67441ce. Removed the on.exit(unlink(tmp)) and replaced it with if (add && ret == 0) unlink(tmp) after the osascript() call. The temp file persists on failure, so the sudo cp ... path in the warning message remains valid for the user to run manually.

…k only on success, consolidate stop() Agent-Logs-Url: https://github.com/rstudio/tinytex/sessions/27d65823-31ba-4ff1-ba16-17c9c18bd877 Co-authored-by: yihui <163582+yihui@users.noreply.github.com>

…-filesystem-security-issues

yihui

in R code, the condition to run macos_path() is currently is_macos(); i want to add another condition: test if /usr/local/bin is writable, if it is, follow the old behavior (i.e., run tlmgr path add); if not, use the new macos_path(); remember to update doc for tlmgr_path() accordingly and roxygenize

same thing for .sh: check if /usr/local/bin is writable

existing TinyTeX users may have already chmod /usr/local/bin, and i don't want to bother them with another sudo command to add /etc/paths.d/TinyTeX

yihui · 2026-03-27T18:27:32Z

R/install.R

+  ret = system(sprintf(
    "/usr/bin/osascript -e 'do shell script \"%s\" with administrator privileges'", cmd
-  )) != 0) warning(
+  ))
+  if (ret != 0) warning(
    "Please run this command in your Terminal (password required):\n  sudo ",
    cmd, call. = FALSE
  )


before running system() command, emit a message() telling users the command to be executed so they know the purpose of requiring the password; after running system(), if it fails, add warning() to tell you to run the command in terminal (don't repeat the command in the warning message since it has been mentioned in message() before)

Done in 71d49e3. osascript() now emits message("Requesting admin privilege to run: sudo ", cmd) before the system() call, and on failure emits warning("Please run the above command in your Terminal (password required).") without repeating the command.

yihui · 2026-03-27T18:32:06Z

R/install.R

+    sprintf('cp \\"%s\\" \\"%s\\"', tmp, paths_file)
+  } else {
+    sprintf('rm -f \\"%s\\"', paths_file)


don't escape quotes here, but do it in osascript() instead; however, in osascript(), you should keep the original cmd instead of overriding it with the escaped version, because in message() you need to output the original cmd, but for /usr/bin/osascript you need to pass the escaped version

otherwise in message() users would see escaped quotes, and the cmd wouldn't be valid for them to run

Done in 71d49e3. macos_path() now uses plain sprintf('cp "%s" "%s"', ...) (no escaping). In osascript(), a local escaped = gsub('"', '\\"', cmd, fixed = TRUE) is used for the shell command passed to /usr/bin/osascript, while the original cmd is used in message() so users see clean, runnable commands.

…ipt(); move quote escaping to osascript() Agent-Logs-Url: https://github.com/rstudio/tinytex/sessions/1bca78ef-48fe-4a0f-bf5c-3be15fdc5da8 Co-authored-by: yihui <163582+yihui@users.noreply.github.com>

Copilot · 2026-03-27T18:40:31Z

in R code, the condition to run macos_path() is currently is_macos(); i want to add another condition: test if /usr/local/bin is writable, if it is, follow the old behavior (i.e., run tlmgr path add...

Done in 71d49e3. Added macos_local_bin_writable() helper (file.access('/usr/local/bin', 2) == 0). Both tlmgr_path() and use_tinytex() now use macos_path() only when is_macos() && !macos_local_bin_writable(), falling back to tlmgr path add when /usr/local/bin is writable. The .sh script on Darwin now checks [ -w /usr/local/bin ] first and runs ./tlmgr path add if true, otherwise falls through to the /etc/paths.d/TinyTeX approach. Doc and Rd updated accordingly.

Initial plan

3f892a5

Copilot AI assigned Copilot and yihui Mar 6, 2026

Copilot started work on behalf of yihui March 6, 2026 21:49 View session

fix filesystem security issues: remove chown -R and restore /usr/loca…

2f27f9e

…l/bin ownership after install Co-authored-by: yihui <163582+yihui@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix filesystem security issues in TinyTex installation~~ Fix macOS /usr/local/bin ownership: drop -R, restore after install Mar 6, 2026

Copilot finished work on behalf of yihui March 6, 2026 21:57

yihui added 3 commits March 26, 2026 23:05

Merge branch 'main' into copilot/fix-filesystem-security-issues

28de5a7

update license year

31aaa1f

Merged origin/copilot/fix-filesystem-security-issues into copilot/fix…

9d17b6e

…-filesystem-security-issues

yihui requested changes Mar 27, 2026

View reviewed changes

Copilot started work on behalf of yihui March 27, 2026 06:30 View session

yihui and others added 2 commits March 27, 2026 01:30

Merge branch 'main' into copilot/fix-filesystem-security-issues

0a2a348

macOS: use /etc/paths.d/TinyTeX instead of symlinks in /usr/local/bin

eea0101

Agent-Logs-Url: https://github.com/rstudio/tinytex/sessions/13dd76fe-b745-4b61-8faf-aa3314531d3e Co-authored-by: yihui <163582+yihui@users.noreply.github.com>

Copilot AI changed the title ~~Fix macOS /usr/local/bin ownership: drop -R, restore after install~~ Fix macOS filesystem security: use /etc/paths.d/TinyTeX instead of touching /usr/local/bin Mar 27, 2026

Copilot AI requested a review from yihui March 27, 2026 06:40

Copilot finished work on behalf of yihui March 27, 2026 06:40

yihui requested changes Mar 27, 2026

View reviewed changes

Copilot started work on behalf of yihui March 27, 2026 14:52 View session

Address review comments: factor macos_path/find_tinytex_bin, idempote…

76970e1

…ncy, osascript returns status, roxygenize Agent-Logs-Url: https://github.com/rstudio/tinytex/sessions/3a5f54ec-a104-4514-843a-93ea370973bf Co-authored-by: yihui <163582+yihui@users.noreply.github.com>

Copilot AI requested a review from yihui March 27, 2026 15:00

Copilot finished work on behalf of yihui March 27, 2026 15:00

yihui requested changes Mar 27, 2026

View reviewed changes

Copilot started work on behalf of yihui March 27, 2026 17:34 View session

Address new review comments: revert install-unx.sh, --no-path flag, m…

14a151f

…acos_path refactor Agent-Logs-Url: https://github.com/rstudio/tinytex/sessions/4ed6cb3b-42e3-4296-9381-ea23c5541e30 Co-authored-by: yihui <163582+yihui@users.noreply.github.com>

Copilot finished work on behalf of yihui March 27, 2026 17:39

Copilot AI requested a review from yihui March 27, 2026 17:39

yihui requested changes Mar 27, 2026

View reviewed changes

Copilot started work on behalf of yihui March 27, 2026 17:55 View session

Address new review comments: --no-path for any OS, quote paths, unlin…

67441ce

…k only on success, consolidate stop() Agent-Logs-Url: https://github.com/rstudio/tinytex/sessions/27d65823-31ba-4ff1-ba16-17c9c18bd877 Co-authored-by: yihui <163582+yihui@users.noreply.github.com>

Copilot finished work on behalf of yihui March 27, 2026 18:03

Copilot AI requested a review from yihui March 27, 2026 18:03

yihui added 3 commits March 27, 2026 13:11

Merged origin/copilot/fix-filesystem-security-issues into copilot/fix…

cbeb770

…-filesystem-security-issues

one liners if-else

6f22065

TeXLive -> TeX Live

42fbe7f

yihui requested changes Mar 27, 2026

View reviewed changes

Copilot started work on behalf of yihui March 27, 2026 18:36 View session

yihui marked this pull request as ready for review March 27, 2026 18:36

Check /usr/local/bin writable on macOS; message()/warning() in osascr…

71d49e3

…ipt(); move quote escaping to osascript() Agent-Logs-Url: https://github.com/rstudio/tinytex/sessions/1bca78ef-48fe-4a0f-bf5c-3be15fdc5da8 Co-authored-by: yihui <163582+yihui@users.noreply.github.com>

Copilot AI changed the title ~~Fix macOS filesystem security: use /etc/paths.d/TinyTeX instead of touching /usr/local/bin~~ Fix macOS filesystem security: use /etc/paths.d/TinyTeX when /usr/local/bin is not writable Mar 27, 2026

Copilot finished work on behalf of yihui March 27, 2026 18:42

Copilot AI requested a review from yihui March 27, 2026 18:42

yihui added 2 commits March 27, 2026 14:15

refactor

598df3e

rewrap

864bb51

yihui mentioned this pull request Mar 27, 2026

fix filesystem security issues #463

Closed

yihui merged commit 68dbf58 into main Mar 27, 2026
12 of 13 checks passed

yihui deleted the copilot/fix-filesystem-security-issues branch March 27, 2026 19:45

Copilot AI mentioned this pull request Mar 27, 2026

Add NEWS.md with full changelog from v0.0 to v0.59 (dev) #494

Merged

	macos_path = function(dir = NULL, add = TRUE) {
	macos_path = function(dir = NULL, action = 'add') {

		if (is_macos()) return(invisible(macos_path(find_tinytex_bin(), action == 'add')))
		tlmgr(c('path', action), .quiet = TRUE)

Conversation

Copilot AI commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Comments on the Issue (you are @copilot in this section)

Uh oh!

CLAassistant commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yihui left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Mar 27, 2026

Uh oh!

yihui left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Mar 27, 2026

Uh oh!

yihui left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 27, 2026

Copilot AI commented Mar 6, 2026 •

edited

Loading

CLAassistant commented Mar 6, 2026 •

edited

Loading